Evaluate request: return memory reference (take 2) #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements 2 things: First, we now return memoory references for all members of an evaluate request's response. This allows for dumping of memory around the results of mundane evaluation, such as variables, structs, etc. Further, any evaluation result which is itself a pointer value gets the contained address as its memory address (as opposed to the load address of the pointer itslef). This in particular allows for dumping of arbitrary memory addresses by simply casting them to (void*) or some equivalent pointer type. This is consistent with other debug adapters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements 2 things:
First, we now return memoory references for all members of an evaluate request's response. This allows for dumping of memory around the results of mundane evaluation, such as variables, structs, etc.
Further, any evaluation result which is itself a pointer value gets the contained address as its memory address (as opposed to the load address of the pointer itslef). This in particular allows for dumping of arbitrary memory addresses by simply casting them to (void*) or some equivalent pointer type. This is consistent with other debug adapters.
@vadimcn I've re-opened this with a much simpler and more correct implementation. You can now dump any address simply by casting it to
(void*)or a pointer. No longer guessing based on it being an integer.here's a demo: